Fix shellTracker incorrectly reporting short-lived commands as running #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in shellStart where the shellId returned from ShellTracker.registerShell() was not being used when updating the shell status, causing short-lived shell commands to remain in the "running" state even after they completed.
Changes
Related Issues
Fixes #379
Testing
Notes
This was a subtle bug where shellStart was generating a UUID with uuidv4() but not using that ID when registering the shell. Instead, ShellTracker.registerShell() was generating its own UUID. When the shell status was later updated, it was using the first UUID, which wasn't associated with any registered shell.